Skip to content

[TEST ONLY] format nox session with ruff#2541

Closed
ohmayr wants to merge 3 commits intoupdate-nox-format-session-to-use-rufffrom
asset-library-changes-with-ruff-format
Closed

[TEST ONLY] format nox session with ruff#2541
ohmayr wants to merge 3 commits intoupdate-nox-format-session-to-use-rufffrom
asset-library-changes-with-ruff-format

Conversation

@ohmayr
Copy link
Contributor

@ohmayr ohmayr commented Jan 28, 2026

asset library test changes

@product-auto-label product-auto-label bot added the size: xl Pull request size is extra large. label Jan 28, 2026
@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Jan 28, 2026

Summary of Changes

Hello @ohmayr, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on enhancing code quality and consistency within the asset golden files by adopting ruff for formatting and linting. The changes streamline import statements, modernize string literal syntax, and improve overall code readability, reflecting an update in development tooling and best practices.

Highlights

  • Code Formatting with Ruff: The pull request integrates 'ruff' for code formatting and linting, specifically for import sorting and general code style, replacing or augmenting previous formatting tools.
  • Import Organization: Python import statements across various __init__.py and client files have been reordered and grouped for consistency and readability, adhering to new formatting rules.
  • Syntax Modernization: The deprecated 'u' prefix for unicode strings has been removed from conf.py files, aligning the code with modern Python 3 practices.
  • Readability Improvements: Multi-line function signatures, warning messages, and dictionary literals have been reformatted for enhanced clarity and adherence to style guidelines.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@ohmayr ohmayr mentioned this pull request Jan 28, 2026
Merged
gemini-code-assist[bot]
gemini-code-assist bot reviewed Jan 28, 2026
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request primarily contains stylistic changes, including reordering and grouping imports, reformatting multi-line function signatures, and adjusting string literals. These changes are consistent with automated code formatting tools like Ruff and generally improve code readability and adherence to Python style conventions. No functional issues or bugs were identified.

@ohmayr ohmayr force-pushed the asset-library-changes-with-ruff-format branch from 5b73572 to efb7a7d Compare January 28, 2026 01:10
@ohmayr ohmayr closed this Jan 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size: xl Pull request size is extra large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ohmayr